Hi Am 14.07.23 um 12:04 schrieb Geert Uytterhoeven:
Hi Thomas, On Fri, Jul 14, 2023 at 9:53 AM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from fbdev and drivers, as briefly discussed at [1]. Both flags were maybe useful when fbdev had special handling for driver modules. With commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0 and have no further effect. Patches 1 to 7 remove FBINFO_DEFAULT from drivers. Patches 2 to 5 split this by the way the fb_info struct is being allocated. All flags are cleared to zero during the allocation. Patches 8 to 16 do the same for FBINFO_FLAG_DEFAULT. Patch 8 fixes an actual bug in how arch/sh uses the token for struct fb_videomode, which is unrelated. Patch 17 removes both flag constants from <linux/fb.h> and patch 18 documents the zero'ed memory returned by framebuffer_alloc(). v3: * sh: include board name in commit message (Adrian) * docs: reword text (Miguel)Thanks for the update!fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers
I wasn't happy about this either. But I could not come up with a description that fits into the 74-char limit for each commit. They only differ in the method of memory allocation. Do you have any ideas?
Four patches with the exact same one-line summary. Please make them unique.fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev driversTwo patches with the exact same one-line summary. Please make them unique.
Same problem here. Best regards Thomas
Gr{oetje,eeting}s,
Geert
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
