Hello Tony,
On 6/30/23 09:20, Tony Lindgren wrote:
Hi,
* Julien Panis <jpanis@xxxxxxxxxxxx> [230629 13:10]:
This series configures usb0 dr_mode as 'peripheral' for am335x-evm,
am335x-evmsk, and am335x-icev2. This USB port is mainly used for
RNDIS and DFU.
Is this a mini-B connector? Just wondering if it was originally attempted
to be configured as OTG or how it ended up with a host configuration..
It's a micro USB-AB connector.
I don't know how it ended up with a host configuration, it looks like an oversight.
Maybe Vignesh or Nishanth can confirm (?)
Initially, a series was submitted to overlay dr_mode in u-boot specific
device trees ('<board>-u-boot.dtsi'):
https://lore.kernel.org/all/20230621-fix_usb_ether_init-v2-0-ff121f0e8d7a@xxxxxxxxxxxx/
It was finally decided to modify linux device trees.
Do we need these as fixes? If so is there a fixes tag for these?
I don't think so.
The u-boot series mentioned above was submitted to fix an error returned
by usb_ether_init() function. This error appeared after changes in u-boot
(arch/arm/mach-omap2/am33xx/board.c). The u-boot commit is:
6815a66ad7430 ("am33xx: musb: Remove unused configuration logic").
But this commit is right actually, and the error appeared because dr_mode
was not properly configured for am335x-evmsk and am335x-icev2 dts.
In other words, this u-boot commit is correct but revealed an oversight
in dr_mode configuration for these boards.
So, there is not a fixes tag here. That was just an omission in device trees.
Regards,
Tony
Julien
