Re: [PATCH v6 1/1] dt-bindings: pinctrl: Update pinctrl-single to use yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> [230608 06:57]:
> On 08/06/2023 08:36, Tony Lindgren wrote:
> > * Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> [230607 18:17]:
> >> On 05/06/2023 11:52, Tony Lindgren wrote:
> >>> +patternProperties:
> >>> +  '-pins$|-pin':
> >>
> >> you did not implement my comments fully, probably we misunderstood each
> >> other. Why do you allow anything after '-pin'? Let's make it pure suffix
> >> for both cases: '-pins?$'
> > 
> > I'll check what kind of node renaming that would cause. At least TI
> > arm64 SoCs use naming like -pins-default and -pins-wakeup. Is your
> > preference to rename all those nodes to -default-pins and -wakeup-pins?
> 
> No, pattern matching TI SoC is fine, but your current also doesn't. Or
> rather - matches by mistake. You do not allow anything after -pins.

So after the earlier dts node name clean-up, looks like it's only few hundred
TI pins to rename. Not sure I want to add SoC specific handling for TI. Folks
will try to use -pins-default, -pins-sleep, -pins-idle etc..

How about let's just fix the remaining dts files and then we can only
allow -pin or -pins suffix? The match would be just '-pins$|-pin$ with a
preference for -pins as it's a group that might get more pins added to it
later on.

Regards,

Tony



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux