On Wed, May 17, 2023 at 9:06 PM Aaro Koskinen <aaro.koskinen@xxxxxx> wrote:
> On Wed, May 17, 2023 at 09:03:49PM +0300, Aaro Koskinen wrote:
> > This patch (now also in gpio-descriptors-omap branch) does not
> > compile:
> >
> > On Sun, Apr 30, 2023 at 07:51:30PM +0200, Linus Walleij wrote:
> > > + pr_err("No interrupt for UART%d wake GPIO\n" idx + 1);
> >
> > Comma is missing. ^^^
Hm I wonder what happened. Allright fixed it up.
> And when tested something goes wrong:
>
> [ 2.555725] (NULL device *): using lookup tables for GPIO lookup
> [ 2.561950] (NULL device *): No GPIO consumer wakeup found
> [ 2.567871] Unable to get UART wakeup GPIO descriptor
> [ 2.573272] (NULL device *): using lookup tables for GPIO lookup
> [ 2.579498] (NULL device *): No GPIO consumer wakeup found
> [ 2.585357] Unable to get UART wakeup GPIO descriptor
> [ 2.590576] (NULL device *): using lookup tables for GPIO lookup
> [ 2.596954] (NULL device *): No GPIO consumer wakeup found
> [ 2.602813] Unable to get UART wakeup GPIO descriptor
>
> There are now two tables with the NULL device - one in the board file,
> and another in serial.c. Maybe that does not work?
Hm I pushed it down to each boardfile NULL device instead.
I sent out a v2, I will update the branch in my git as well as soon
as I looked into your other review comments.
Yours,
Linus Walleij
