On 09/05/23 02:22, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-omap.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 4199f57a6bf2..58fd6fa3edf1 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -1519,7 +1519,7 @@ omap_i2c_probe(struct platform_device *pdev) > return r; > } > > -static int omap_i2c_remove(struct platform_device *pdev) > +static void omap_i2c_remove(struct platform_device *pdev) > { > struct omap_i2c_dev *omap = platform_get_drvdata(pdev); > int ret; > @@ -1535,8 +1535,6 @@ static int omap_i2c_remove(struct platform_device *pdev) > pm_runtime_dont_use_autosuspend(&pdev->dev); > pm_runtime_put_sync(&pdev->dev); > pm_runtime_disable(&pdev->dev); > - > - return 0; > } > > static int __maybe_unused omap_i2c_runtime_suspend(struct device *dev) > @@ -1588,7 +1586,7 @@ static const struct dev_pm_ops omap_i2c_pm_ops = { > > static struct platform_driver omap_i2c_driver = { > .probe = omap_i2c_probe, > - .remove = omap_i2c_remove, > + .remove_new = omap_i2c_remove, > .driver = { > .name = "omap_i2c", > .pm = &omap_i2c_pm_ops, Reviewed-by: Vignesh Raghavendra <vigneshr@xxxxxx> -- Regards Vignesh