Hi, On Sun, 2 Apr 2023 12:55:18 +0200 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > One of the first things that the driver's pm_runtime_resume callback > does is to write zero to the OMAP_I2C_CON_REG register. > So there is no need to have the device resumed just to write to the > OMAP_I2C_CON_REG register and the call to pm_runtime_resume_and_get() > can be dropped. > > The intended side effect of this commit is to remove an error path of > the function resulting in the remove callback returning a mostly ignored > error code. This prepares changing the prototype of struct > platform_driver's remove callback to return void. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> As far as I have understand the code that runtime resume is needed for enabling clocks to access the device Regards, Andreas