* Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [230329 09:08]: > On Thu, Mar 23, 2023 at 09:10:47AM +0200, Tony Lindgren wrote: > > --- /dev/null > > +++ b/drivers/tty/serial/serial_base.c > > @@ -0,0 +1,142 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > Given that the driver core is "GPL-2.0-only", why is this -or-later? Thanks for noticing, the intention was to set it to what serial_core.c has: $ git grep -e SPDX -e MODULE_LICENSE drivers/tty/serial/serial_core.c drivers/tty/serial/serial_core.c:// SPDX-License-Identifier: GPL-2.0+ drivers/tty/serial/serial_core.c:MODULE_LICENSE("GPL"); > No copyright notice? That's fine, but again, I have to ask. Will add thanks. Tony