On Sun, Mar 19, 2023 at 1:02 PM Lizhe <sensor1010@xxxxxxx> wrote: > platform_set_drvdata() is redundant in these functions. > the purpose of calling this function is to place data > in *driver_data. but the data is not retrieved in these > functions > > Signed-off-by: Lizhe <sensor1010@xxxxxxx> You have to also ascertain that the data is not used elsewhere like in some callbacks or even in other drivers in some odd cases. Yours, Linus Walleij