Re: [PATCH] ASoC: do not include pm_runtime.h if not used

Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> · Fri, 10 Mar 2023 07:29:04 +0000

On 07/03/2023 10:30, Claudiu Beznea wrote:

diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
index 41db6617e2ed..dc892fac4baa 100644
--- a/sound/soc/qcom/lpass-sc7180.c
+++ b/sound/soc/qcom/lpass-sc7180.c
@@ -12,7 +12,6 @@
  #include <linux/module.h>
  #include <linux/of.h>
  #include <linux/platform_device.h>
-#include <linux/pm_runtime.h>
  #include <dt-bindings/sound/sc7180-lpass.h>
  #include <sound/pcm.h>
  #include <sound/soc.h>
diff --git a/sound/soc/qcom/lpass-sc7280.c b/sound/soc/qcom/lpass-sc7280.c
index d43f480cbae3..ee4a4b553e74 100644
--- a/sound/soc/qcom/lpass-sc7280.c
+++ b/sound/soc/qcom/lpass-sc7280.c
@@ -8,7 +8,6 @@
  #include <linux/module.h>
  #include <sound/pcm.h>
  #include <sound/soc.h>
-#include <linux/pm_runtime.h>
  
  #include <dt-bindings/sound/sc7180-lpass.h>

Has these been compile tested? the reason I ask is because both these 
drivers need SET_SYSTEM_SLEEP_PM_OPS macro from pm.h which was getting 
included from pm_runtime.h, now that is removed, am guessing it will 
cause a compile errors.

can you atleast replace this with pm.h instead of removing it totally?

--srini






