Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on tty/tty-next tty/tty-linus rafael-pm/linux-next usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.3-rc1 next-20230309] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tony-Lindgren/serial-core-Start-managing-serial-controllers-to-enable-runtime-PM/20230309-170149 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing patch link: https://lore.kernel.org/r/20230309085713.57700-1-tony%40atomide.com patch subject: [PATCH v6 1/1] serial: core: Start managing serial controllers to enable runtime PM config: x86_64-kexec (https://download.01.org/0day-ci/archive/20230310/202303100516.22vtkWv4-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/08f76f28e32bcd3c093e4af349b0e1b60328395e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Tony-Lindgren/serial-core-Start-managing-serial-controllers-to-enable-runtime-PM/20230309-170149 git checkout 08f76f28e32bcd3c093e4af349b0e1b60328395e # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/tty/serial/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303100516.22vtkWv4-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from include/linux/device.h:25, from include/linux/pm_runtime.h:11, from drivers/tty/serial/serial_ctrl.c:12: >> drivers/tty/serial/serial_ctrl.c:17:34: warning: 'serial_ctrl_pm' defined but not used [-Wunused-const-variable=] 17 | static DEFINE_RUNTIME_DEV_PM_OPS(serial_ctrl_pm, NULL, NULL, NULL); | ^~~~~~~~~~~~~~ include/linux/pm.h:372:25: note: in definition of macro '_DEFINE_DEV_PM_OPS' 372 | const struct dev_pm_ops name = { \ | ^~~~ drivers/tty/serial/serial_ctrl.c:17:8: note: in expansion of macro 'DEFINE_RUNTIME_DEV_PM_OPS' 17 | static DEFINE_RUNTIME_DEV_PM_OPS(serial_ctrl_pm, NULL, NULL, NULL); | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/serial_ctrl_pm +17 drivers/tty/serial/serial_ctrl.c 2 3 /* 4 * Serial core controller driver 5 * 6 * This driver manages the serial core controller struct device instances. 7 * The serial core controller devices are children of the physical serial 8 * port device. 9 */ 10 11 #include <linux/module.h> > 12 #include <linux/pm_runtime.h> 13 #include <linux/serial_core.h> 14 15 #include "serial_base.h" 16 > 17 static DEFINE_RUNTIME_DEV_PM_OPS(serial_ctrl_pm, NULL, NULL, NULL); 18 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
