Re: [PATCH 0/8] ARM: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Mar 08, 2023 at 04:06:47PM +0100, Arnd Bergmann wrote:
> On Wed, Mar 8, 2023, at 11:00, Uwe Kleine-König wrote:
> > Hello,
> >
> > this patch series adapts the platform drivers below arch/arm to use the
> > .remove_new() callback. Compared to the traditional .remove() callback
> > .remove_new() returns no value. This is a good thing because the driver core
> > doesn't (and cannot) cope for errors during remove. The only effect of a
> > non-zero return value in .remove() is that the driver core emits a warning. The
> > device is removed anyhow and an early return from .remove() usually yields a
> > resource leak.
> >
> > By changing the remove callback to return void driver authors cannot
> > reasonably assume any more that there is some kind of cleanup later.
> >
> > All drivers in arch/arm returned zero unconditionally in their remove callback,
> > so they could all be converted trivially to .remove_new().
> >
> > Note that this series depends on commit 5c5a7680e67b ("platform: Provide
> > a remove callback that returns no value") which is included in v6.3-rc1.
> Looks good to me,
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
> > I'm unsure who will pick up this series. Will it go as a whole via arm-soc? Or
> > will the individual maintainers pick it up?
> I can take it through the soc tree, please send it to
> soc@xxxxxxxxxx once you are done getting Acks.
> Since all eight patches in the series have the exact same
> changelog text and are all trivial, I'd prefer them to be
> folded into a single patch if that works for you.

No, they are not all identical, they all have their individual subject
prefix :-)

Honestly: I don't care much. I split it because for most other
subsystems that's what the respective maintainers seem to prefer.

I'll care for that, i.e. wait a bit to give others the chance to ack (or
object) and then send it as you recommended. Thanks.

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | |

Attachment: signature.asc
Description: PGP signature

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux