On Sun, Feb 19, 2023 at 3:38 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote: > > The devres variant of thermal_add_hwmon_sysfs() only takes the thermal > zone structure pointer as parameter. > > Actually, it uses the tz->device to add it in the devres list. > > It is preferable to use the device registering the thermal zone > instead of the thermal zone device itself. That prevents the driver > accessing the thermal zone structure internals and it is from my POV > more correct regarding how devm_ is used. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > --- > drivers/thermal/amlogic_thermal.c | 2 +- For amlogic_thermal.c: Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
