Hi, * Linus Walleij <linus.walleij@xxxxxxxxxx> [230216 09:38]: > Convert the driver to immutable irq-chip with a bit of > intuition. > > This driver require some special care: .irq_ack() was copied > from dummy_irq_chip where it was defined as noop. This only > makes sense if using handle_edge_irq() that will unconditionally > call .irq_ack() to avoid a crash, but this driver is not ever > using handle_edge_irq() so just avoid assigning .irq_ack(). > > A separate chip had to be created for the non-wakeup instance. Nice, works for me. BTW, I still see these warnings remaining on boot: gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation. Seems like we might be able to get rid of those too now or are there still some dependencies with /sys/class/gpio for example? Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx> Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>
