On Fri, Aug 07, 2009 at 08:59:30PM +0530, Anuj Aggarwal wrote: > + }, > + .num_consumer_supplies = 1, > + .consumer_supplies = &tps65023_core_consumers, > + }, This is all OK but as a style thing it's better to use ARRAY_SIZE() for the number of consumers even if there's just one since that way if someone adds another consumer they don't need to remember to adjust the array length. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html