On 7 January 2023 21:53:46 CET, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: >Hi Stephen. > >On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint <devnull+sam.ravnborg.org@xxxxxxxxxx> wrote: >> >From: Sam Ravnborg <sam@xxxxxxxxxxxx> >> > >> >The atmel_lcdfb had code to save/restore power state. >> >This is not needed so drop it. >> > >> >Introduce backlight_is_brightness() to make logic simpler. >> > >> >Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> >> >Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx> >> >Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> >> >Cc: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx> >> >Cc: linux-fbdev@xxxxxxxxxxxxxxx >> >Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >> >--- >> > drivers/video/fbdev/atmel_lcdfb.c | 24 +++--------------------- >> > 1 file changed, 3 insertions(+), 21 deletions(-) >... >> >> Hi Sam, >> >> I’d submitted quite a few more of these previously (and you’d reviewed them), see e.g. the thread starting at https://lkml.org/lkml/2022/6/7/4365, and yesterday, https://lkml.org/lkml/2023/1/6/520, https://lkml.org/lkml/2023/1/6/656, https://lkml.org/lkml/2023/1/6/970, https://lkml.org/lkml/2023/1/6/643, and https://lkml.org/lkml/2023/1/6/680. There are a few more, I can find them if it’s any use. > >The patches from yesterday was what triggered me to resurrect an old >branch of mine where I had done something similar. I had lost all >memory of reviewing similar patches from you. > > >Helge - could you pick the reviewed patches from: >https://lore.kernel.org/all/20220607192335.1137249-1-steve@xxxxxxx/ >[This is the same mail as Stephen refer to above - looked up via lore]. > >Stephen - I expect Daniel/Lee to take care of the patches from yesterday. >If you can look up other pending patches from you please do so, so we >can have them applied. >Preferably with links to lore - as this makes it easier to apply them. > >Review of what is unique in this set would be appreciated. > > Sam Hi Sam, Here are my pending patches from last June on lore: * https://lore.kernel.org/lkml/20220607190925.1134737-1-steve@xxxxxxx/ * https://lore.kernel.org/lkml/20220608205623.2106113-1-steve@xxxxxxx/ * https://lore.kernel.org/lkml/20220607192335.1137249-1-steve@xxxxxxx/ * https://lore.kernel.org/lkml/20220616170425.1346081-1-steve@xxxxxxx/ I’ll send reviews of your other patches later today or tomorrow. Regards, Stephen
