On Tue, Dec 06, 2022 at 12:15:17PM +0200, Roger Quadros wrote: > On 06/12/2022 12:05, Leon Romanovsky wrote: > > On Tue, Dec 06, 2022 at 11:44:13AM +0200, Roger Quadros wrote: > >> Hi, > >> > >> This contains a critical bug fix for the recently merged suspend/resume > >> support [1] that broke set channel operation. (ethtool -L eth0 tx <n>) > >> > >> As there were 2 dependent patches on top of the offending commit [1] > >> first revert them and then apply them back after the correct fix. > > > > Why did you chose revert and reapply almost same patch instead of simply > > fixing what is missing? > > v1 & 2 of this series were doing that but it was difficult to review. > This is because we are taking a different approach so we have to undo > most of the things done earlier. > > It was suggested during review that reverting and fresh patch was better. Thanks.