Hi Tony, On Wed, Nov 9, 2022 at 9:17 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Tony Lindgren <tony@xxxxxxxxxxx> [221109 08:06]: > > * Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx> [221106 17:36]: > > > The ti_clk_register() function is always called with the parameter of > > > type struct device set to NULL, since the functions from which it is > > > called always have a parameter of type struct device_node. Adding this > > > helper will allow you to register a TI clock to the common clock > > > framework by taking advantage of the facilities provided by the > > > struct device_node type. > > > > Makes sense to me. > > > > Do you have a patch to make use of this I can test with? > > I mean a patch to convert the ti_clk_register() callers to use this or > what's your plan? The first patch that calls this function is the second one in this series "clk: ti: dra7-atl: don't allocate` parent_names' variable ". Since I don't have the dra7 hardware, I have indirectly tested it on a beaglebone (gate clock driver) board. To do this I also had to add the of_ti_clk_register_omap_hw() helper. In the case of the dra7-atl driver it was not necessary because the setup function calls the ti_clk_register() directly. If you think it makes sense, I can do 1 or more patches that replace ti_clk_register() and ti_clk_register_omap_hw() with their counterparts of_ti_clk_register[_omap_hw]. And I could test this further series on the beaglebone board. Thanks and regards, Dario > > Regards, > > Tony -- Dario Binacchi Embedded Linux Developer dario.binacchi@xxxxxxxxxxxxxxxxxxxx __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@xxxxxxxxxxxxxxxxxxxx www.amarulasolutions.com
