RE: [PATCH 3/9] ehci: correct EHCI init parameters on OMAP3EVM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-
> omap2/board-omap3evm.c
> > index 595beac..b497979 100644
> > --- a/arch/arm/mach-omap2/board-omap3evm.c
> > +++ b/arch/arm/mach-omap2/board-omap3evm.c
> > @@ -308,7 +308,9 @@ static void __init omap3_evm_init(void)
> >
> >  	omap_serial_init();
> >  	usb_musb_init();
> > -	usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, true, true, 57, 61);
> > +	/* Setup EHCI phy reset padconfig */
> > +	omap_cfg_reg(AF4_34XX_GPIO135_OUT);
> > +	usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, false, true, -EINVAL, 135);
> >  	ads7846_dev_init();
> >  }
> 
> Is this safe to do if you don't have the daughter card? If so, maybe
> add a comment for it.

Yes, it is safe for OMAP3EVM even if there is no DC but we can add comment as you suggested.

> 
> I guess the nicest thing would be to wait until the daughter card
> is probed based on some I2C chip id and only then mux the pins.

I agree that this would be the best but this requires OMAP3EVM DC related patch from Vaibhav which is still under review.

I feel we can add this logic once other dependent patches are accepted.

-Ajay
> 
> Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux