[+cc Pali, heads-up for trivial addition of <linux/irqdomain.h> to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain' > > struct mc_pcie *port = domain->host_data; > > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs <linux/irqdomain.h>, but it currently gets it via <linux/of_irq.h>, which it doesn't otherwise need. I added a preparatory patch to include <linux/irqdomain.h> explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting <linux/irqdomain.h> via <linux/of_irq.h>, but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn
