Hi All, Le 27/09/2022 à 10:04, Vignesh Raghavendra a écrit : > > > On 27/09/22 12:10, Tony Lindgren wrote: >> Hi, >> >> * Romain Naour <romain.naour@xxxxxxxx> [220921 08:13]: >>> Ok, I understand what's going on... >>> >>> The issue appear on the merge commit since on a omap side there was the switch >>> to ti-sysc (devicetree interconnect description) and on upstream side there was >>> a change on driver core behavior with fw_devlink=on being set by default: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ea718c699055c8566eb64432388a04974c43b2ea >> >> OK good to hear it's not the change to ti-sysc. That should be all pretty >> much standard Linux driver related changes. >> >>> Actually the issue is really on the TI's prueth and IEP driver whith >>> fw_devlink=on. The IEP driver probe correctly with fw_devlink=permissive. >> >> Argh not again, the fw_devlink changes seem to be causing all kind of >> issues. Any ideas what the issue here might be? It might be worth testing >> with v6.0-rc7 too as it has a series of fixes to related issues. I rebased the prueth + IEP series on v6.0-rc7 and indeed the driver probe correctly but with some delay due deferred probe. [ 9.568817] remoteproc remoteproc0: 4b234000.pru is available [ 9.580505] remoteproc remoteproc1: 4b238000.pru is available [ 9.625701] remoteproc remoteproc2: 4b2b4000.pru is available [ 9.632110] remoteproc remoteproc3: 4b2b8000.pru is available [ 9.932952] prueth pruss1_eth: unable to get IEP [ 10.238098] prueth pruss1_eth: unable to get IEP [ 10.469421] prueth pruss1_eth: unable to get IEP [ 10.675445] prueth pruss1_eth: unable to get IEP [ 10.885589] prueth pruss1_eth: unable to get IEP [ 11.117126] prueth pruss1_eth: unable to get IEP [ 11.755462] prueth pruss1_eth: unable to get IEP [ 12.316192] prueth pruss1_eth: unable to get IEP [ 13.387969] prueth pruss1_eth: unable to get IEP [ 14.175750] prueth pruss1_eth: unable to get IEP [ 14.388671] prueth pruss1_eth: unable to get IEP [ 14.648406] prueth pruss1_eth: unable to get IEP [ 16.946716] prueth pruss1_eth: unable to get IEP [ 25.037414] remoteproc remoteproc1: powering up 4b238000.pru [ 25.056793] remoteproc remoteproc1: Booting fw image ti-pruss/am57xx-pru1-prueth-fw.elf, size 6952 [ 25.065856] remoteproc remoteproc1: unsupported resource 5 [ 25.071472] remoteproc remoteproc1: remote processor 4b238000.pru is now up [ 25.157104] remoteproc remoteproc0: powering up 4b234000.pru [ 25.165527] remoteproc remoteproc0: Booting fw image ti-pruss/am57xx-pru0-prueth-fw.elf, size 6920 [ 25.174713] remoteproc remoteproc0: unsupported resource 5 [ 25.180328] remoteproc remoteproc0: remote processor 4b234000.pru is now up [ 27.047607] prueth pruss1_eth eth4: Link is Up - 100Mbps/Full - flow control off >> > > Could you also try [1] from Puranjay's series? He did have to rework > pru_rproc_get()/pru_rproc_put() a bit to fix few probe failures seen > only on > 5.11 kernels. > > [1] https://lore.kernel.org/netdev/20220406094358.7895-3-p-mohan@xxxxxx/ > Thank for the link, I actually had a look to this series and updated the pru remote proc driver. Note: The RFC series "PRUSS Remoteproc, Platform APIS, and Ethernet Driver" doesn't include yet the prueth driver for AM57xx so I had to fixup this driver when needed. It would be great if the support for the AM57xx can be included in the next submission [1]. [1] https://lore.kernel.org/linux-remoteproc/992019ad-5c58-d420-8a18-a82228f8e086@xxxxxxxx/ Best regards, Romain
