Benedikt, On 06/09/2022 15:47, B. Niedermayr wrote: > From: Benedikt Niedermayr <benedikt.niedermayr@xxxxxxxxxxx> > > The GPMC controller has the ability to configure the polarity for the > wait pin. The current properties do not allow this configuration. > This binding directly configures the WAITPIN<X>POLARITY bit > in the GPMC_CONFIG register. > > Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@xxxxxxxxxxx> > --- > .../bindings/memory-controllers/ti,gpmc-child.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml > index 6e3995bb1630..a115b544a407 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml > @@ -230,6 +230,12 @@ properties: > Wait-pin used by client. Must be less than "gpmc,num-waitpins". > $ref: /schemas/types.yaml#/definitions/uint32 > > + gpmc,wait-pin-active-low: > + description: | > + Set the polarity for the selected wait pin to active low. > + Defaults to active high if this is not set. > + type: boolean > + I just checked that the default behaviour is active low. Reset value of the polarity register field is 0, which means active low. We will need to use the property "gpmc,wait-pin-active-high" instead. Sorry for not catching this earlier. > gpmc,wait-on-read: > description: Enables wait monitoring on reads. > type: boolean cheers, -roger
