Hi Benedikt, On 05/09/2022 10:17, B. Niedermayr wrote: > From: Benedikt Niedermayr <benedikt.niedermayr@xxxxxxxxxxx> > > Add a new dt-binding for the wait-pin-polarity property > > Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@xxxxxxxxxxx> > --- > .../bindings/memory-controllers/ti,gpmc-child.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml > index 6e3995bb1630..7c721206f10b 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc-child.yaml > @@ -230,6 +230,13 @@ properties: > Wait-pin used by client. Must be less than "gpmc,num-waitpins". > $ref: /schemas/types.yaml#/definitions/uint32 > > + gpmc,wait-pin-polarity: > + description: | > + Wait-pin polarity used by the clien. It relates to the pin defined did you mean "client?" Can you please specify what value is for Active Low vs Active High? > + with "gpmc,wait-pin". > + $ref: /schemas/types.yaml#/definitions/uint32 Why can't type be boolean? > + default: 0 > + > gpmc,wait-on-read: > description: Enables wait monitoring on reads. > type: boolean cheers, -roger