Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix compile test warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 15, 2022 at 2:03 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>
> We can get a warning with COMPILE_TEST enabled for omap_timer_match
> for 'omap_timer_match' defined but not used.
>
> Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
>  drivers/clocksource/timer-ti-dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
> --- a/drivers/clocksource/timer-ti-dm.c
> +++ b/drivers/clocksource/timer-ti-dm.c
> @@ -1040,7 +1040,7 @@ static const struct dmtimer_platform_data am6_pdata = {
>         .timer_ops = &dmtimer_ops,
>  };
>
> -static const struct of_device_id omap_timer_match[] = {
> +static const __maybe_unused struct of_device_id omap_timer_match[] = {
>         {
>                 .compatible = "ti,omap2420-timer",
>         },

I think a better way to address this is to remove the of_match_ptr()
usage from the driver. The only reason to use of_match_ptr() is to save
a few bytes on machines that don't have CONFIG_OF enabled, but this
driver is not used on such machines any more.

         Arnd



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux