Kevin Hilman wrote:
Steve Sakoman wrote:On Wed, Aug 5, 2009 at 10:58 AM, Kevin Hilman<khilman@xxxxxxxxxxxxxxxxxxx> wrote:Steve Sakoman wrote:And up to now in each case I shrug and say "no time to do that now, I'll just leave kernel pinmuxing turned off and do it in u-boot"I agree there are lots of shortcomings in the current mux code and we've been hitting them regularily lately.That being said, for mux settings that done one-time only at boot, what arethe problems you're running into?It's been a few months since I last encountered this, so the exact details are a bit fuzzy. I seem to recall that there were some basic issues with enabling kernel pinmuxing in that some of the setup that was done for all machines was just wrong for my particular machine. IIRC, it was due to assumptions about which pad was used for a particular function (for those functions which can be steered to multiple GPIO pads). So I faced having to undo that change in my board file as well as any issues that may have arisen from glitches on the GPIO pins during the process. And since there were several of these I gave up and turned off kernel pinmuxing. I'd be happy if we cleaned up the "one size fits all" pinmuxing to just that subset that truly does fit all boards, and leave the rest to the board files. I'd also be content to have it all done in the board file for each machine.Indeed, any assumptions about common muxing that are not indeed common are bugs and should be fixed.The "right" solution is to have everything in the kernel, and split across SoC "common" init and board specific init. Of course u-bootwill still have to do some early muxing, but it should be redone in the kernel so it's trivial to change bootloaders. So the real missing piece is someone to step up and rework the mux code.The bigger problem is that the vast majority of folks don't care about the common case and only care about getting thing working for a specific platform.
I posted some changes to add support for changing the Beagle expansion connector MCSPI muxing in the board file and some general muxing questions and received no comments (OK, a number of people were on vacation). If people would like I can repost it to aid in discussion.
I agree we need to more muxing in the kernel and less in u-boot. I do not want a different u-boot for the Beagle based on what I have connected to the expansion connector. (Same applies to the Overo)
The current mux requires you make an entry in an enum, then a corresponding entry in an array to configure the pin. SO the enum length is basically number of pins * the number of possible pin configurations.
There is no way to account for the different packages the OMAP3 is available in.
Is the code omap specific, or is it shared with other chips? Philip
Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
