On 16/05/22 11:06 pm, Guillaume LA ROQUE wrote: > Le 16/05/2022 à 18:48, Nishanth Menon a écrit : >> On 16:54-20220516, Guillaume La Roque wrote: >>> Enable ramoops features to easily debug some issues >>> >>> Signed-off-by: Guillaume La Roque <glaroque@xxxxxxxxxxxx> >>> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxx> >>> --- >>> Changes in v2: >>> - Apply script create-mem_map.py with args given by Nishanth Menon >>> - Spelling fix >>> --- >>> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts >>> b/arch/arm64/boot/dts/ti/k3-am625-sk.dts >>> index 0de4113ccd5d..dfb16c29a000 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts >>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts >>> @@ -36,6 +36,15 @@ reserved-memory { >>> #size-cells = <2>; >>> ranges; >>> >>> + ramoops@0x9ca00000 { >>> + compatible = "ramoops"; >>> + reg = <0x0 0xe0000000 0x0 0x00100000>; >> I think you intended 0x9ca00000 here? >> >> Static checks should have caught this for you. please run them >> prior to posting? > sorry for that i forgot to run it and update line . > > i will fix it . > > sorry for noise... > Also, convention in the file is to use 0x00 instead of 0x0. So, reg = <0x00 0x9ca00000 0x00 0x100000>; >>> + record-size = <0x8000>; >>> + console-size = <0x8000>; >>> + ftrace-size = <0x0>; >>> + pmsg-size = <0x8000>; >>> + }; >>> + >>> secure_tfa_ddr: tfa@9e780000 { >>> reg = <0x00 0x9e780000 0x00 0x80000>; >>> alignment = <0x1000>; >>> -- >>> 2.25.1 >>> >