On 06/05/2022 09:27, Gireesh.Hiremath@xxxxxxxxxxxx wrote: >> >>> both matric_keypad.c and mt_matrix_kepad.c logically operate differently, >>> my openion is not to merge both. >> >> IMHO from the user/system-integrator pov it is looking the same and so >> one driver should be fine. To distinguish between both modes we could >> add dt-property or add a new dt-compatible like "gpio-matrix-keypad-v2". >> > > as mentioned above our keypad is not complete matrix keypad and it will > not be compatible with matrix_keypad diver. that is the reason we derived > mt matrix keypad driver. > > to avoid confusion, we will rename the driver as bosch_mt_keypad.c > if you suggest. Sending a new version while discussions are ongoing is not how we reach consensus. Make the driver as part of matrix-keypad driver or bring real arguments why it cannot be merged. Best regards, Krzysztof
