On 26/04/2022 10:26, Roger Quadros wrote: > Allow OMAP_GPMC to be built as a module. > > When building this driver as a module, the symbol > 'of_default_bus_match_table' will not be found > as it is not being exported. > > The of_match_node() call is redundant anyways as > of_platform_default_populate() already takes care of > matching with 'of_default_bus_match_table'. So get > rid of that call. This will also resolve the > module build failure. > > Move compatible match table to the end where it is > usually expected. Don't use some unusual wrapping style. Read instead: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 Best regards, Krzysztof