* Tony Lindgren <tony@xxxxxxxxxxx> [220407 08:50]: > * Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> [220407 08:23]: > > On 07/04/2022 10:15, Tony Lindgren wrote: > > > * Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> [220407 08:01]: > > > > On 07/04/2022 09:10, Tony Lindgren wrote: > > > > > @@ -251,7 +251,8 @@ int omap_dm_timers_active(void); > > > > > * The below are inlined to optimize code size for system timers. Other code > > > > > * should not need these at all. > > > > > */ > > > > > -#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) > > > > > +#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) || \ > > > > > + defined(CONFIG_ARCH_K3) > > > > > > > > Why not replace the above by CONFIG_OMAP_DM_TIMER ? > > > > > > Hmm that's a good question for why it was not that way earlier. > > > > > > This series changes things for tristate "OMAP dual-mode timer driver" if > > > ARCH_K3 || COMPILE_TEST though. So the inline stubs are still needed for > > > COMPILE_TEST it seems. > > > > But if ARCH_K3 or COMPILE_TEST is set, CONFIG_DM_TIMER is also set, no? > > Right but I suspect that COMPILE_TEST will produce a build error on other > architectures. I need to check that though, maybe that is no longer the > case. We could use IS_ENABLED(CONFIG_OMAP_DM_TIMER), but looks like we can now just move the __omap_dm_timer_* inline functions to timer-ti-dm.c instead. I'll do that and repost after some testing. Regards, Tony
