On Wednesday 05 August 2009 10:39:00 ext Jarkko Nikula wrote: > On Thu, 30 Jul 2009 15:49:34 +0300 > > Eduardo Valentin <eduardo.valentin@xxxxxxxxx> wrote: > > From: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> > > > > + > > + return sprintf(buf, "%d\n", dma_op_mode); > > It would be good to handle this as an ascii like e.g /sys/power/state > does. "element", "threshold" or "frame". A number value doesn't tell > much (for me when testing). At least when reading it it would be nice to have asci, like "element (0)", "threshold (1)"... > > I would say the default mode for the omap34xx should be also element as > it keeps the omap_pcm_pointer behavior the same than currently and > avoids possible regression. Yes, the default mode should be the element mode in my opinion as well. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
