Re: [PATCH v1 1/3] ARM:OMAP4 iommu:changes in iommu for OMAP4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [090805 01:45]:
> On Tue, Aug 04, 2009 at 05:30:23PM -0500, Kanigeri, Hari wrote:
> > -	obj->clk = clk_get(&pdev->dev, pdata->clk_name);
> > -	if (IS_ERR(obj->clk))
> > -		goto err_clk;
> > +	/*
> > +	 * FIX-ME: Replace with correct clk node when clk
> > +	 * framework is available
> > +	 */
> > +	if (!cpu_is_omap44xx())	{
> > +		obj->clk = clk_get(&pdev->dev, pdata->clk_name);
> > +		if (IS_ERR(obj->clk))
> > +			goto err_clk;
> > +	}
> 
> I've no visibility on when these are going to get resolved, and it's
> starting to concern me that there appears to be no progress on it,
> especially as we have more and more code being merged with these
> workarounds.  It's getting towards the point where enough is enough
> and we need OMAP4 clk support in place, even if it is just a simple
> stop-gap implementation rather than all these horrible hacks spread
> through the code which one day will need to be found and removed.

Yeah I agree.

Tony

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux