Re: [PATCH v1 3/3] ARM:OMAP4 iommu:provide build support for omap4 iommu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 04, 2009 at 05:32:12PM -0500, Kanigeri, Hari wrote:
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index efe85d0..50aaefb 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -118,8 +118,11 @@ config OMAP_MBOX_FWK
>  	  DSP, IVA1.0 and IVA2 in OMAP1/2/3.
>  
>  config OMAP_IOMMU
> -	tristate
> -
> +	tristate "iommu"

Insufficiently verbose description.  "OMAP IOMMU Support" would be
better.  I thought the idea here was to arrange for things to select
OMAP_IOMMU when they require it rather than offering it as a separate
configuration option.

The former way has the advantage that you don't need to know that you
need IOMMU support to (eg) use the Camera - enabling the Camera
should automatically enable IOMMU support.


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux