RE: [PATCH 2/2] DSPBRIDGE: introduce VMA checking for cache operation

["Ramirez Luna, Omar" <omar.ramirez@xxxxxx>]

Hi Doyu-san,

>From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx]
>Sent: Wednesday, July 22, 2009 3:23 AM
>To: linux-omap@xxxxxxxxxxxxxxx
>Cc: Menon, Nishanth; ameya.palande@xxxxxxxxx; Ramirez Luna, Omar; Guzman Lugo, Fernando; Kanigeri,
>Hari; Hiroshi DOYU
>Subject: [PATCH 2/2] DSPBRIDGE: introduce VMA checking for cache operation
>
>Check if the given area blongs to process virtul memory address space.
>
>Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx>
>---
> drivers/dsp/bridge/rmgr/proc.c |   32 ++++++++++++++++++++++++++++++++
> 1 files changed, 32 insertions(+), 0 deletions(-)
>

Is this patch solving any specific issue?

>diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c
>index 3a2879f..fe9dabf 100644
>--- a/drivers/dsp/bridge/rmgr/proc.c
>+++ b/drivers/dsp/bridge/rmgr/proc.c
>@@ -735,6 +735,30 @@ DSP_STATUS PROC_EnumNodes(DSP_HPROCESSOR hProcessor, OUT DSP_HNODE *aNodeTab,
> 	return status;
> }
>
>+/* Check if the given area blongs to process virtul memory address space */
>+static int memory_check_vma(unsigned long start, u32 len)
>+{
>+	int err = 0;
>+	unsigned long end;
>+	struct vm_area_struct *vma;
>+
>+	len = PAGE_ALIGN(len);
>+	end = start + len;
>+	if (end <= start)
>+		return -EINVAL;
>+
>+	down_read(&current->mm->mmap_sem);
>+
>+	vma = find_vma(current->mm, start);
>+	if (!vma || start < vma->vm_start) {
>+		pr_err("%s: no vma for %08lx %08lx\n", __func__, start, end);
>+		err = -EINVAL;
>+	}
>+
>+	up_read(&current->mm->mmap_sem);
>+
>+	return err;
>+}
>
> static DSP_STATUS proc_memory_sync(DSP_HPROCESSOR hProcessor, void *pMpuAddr,
> 				   u32 ulSize, u32 ulFlags,
>@@ -757,6 +781,14 @@ static DSP_STATUS proc_memory_sync(DSP_HPROCESSOR hProcessor, void *pMpuAddr,
> 		goto err_out;
> 	}
>
>+	if (memory_check_vma((u32)pMpuAddr, ulSize)) {
>+		GT_3trace(PROC_DebugMask, GT_7CLASS,
>+			  "%s: InValid address parameters\n",
>+			  __func__, pMpuAddr, ulSize);
>+		status = DSP_EHANDLE;
>+		goto err_out;
>+	}
>+
> 	(void)SYNC_EnterCS(hProcLock);
> 	MEM_FlushCache(pMpuAddr, ulSize, FlushMemType);
> 	(void)SYNC_LeaveCS(hProcLock);
>--
>1.6.0.4
>

Regards,

Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html