-----Original Message----- From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Shilimkar, Santosh Sent: Tuesday, August 04, 2009 1:27 PM To: Tony Lindgren; Mark Brown Cc: Krishnamoorthy, Balaji T; linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxxxxxxxxxxxxxxx; david-b@xxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; sameo@xxxxxxxxxxxxxx; wim@xxxxxxxxx; timo.t.kokkonen@xxxxxxxxx; ben-linux@xxxxxxxxx; lrg@xxxxxxxxxxxxxxx; Nayak, Rajendra Subject: RE: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to create twl6030 regulators > -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Tony Lindgren > Sent: Tuesday, August 04, 2009 1:16 PM > To: Mark Brown > Cc: Krishnamoorthy, Balaji T; linux-omap@xxxxxxxxxxxxxxx; > khilman@xxxxxxxxxxxxxxxxxxx; david-b@xxxxxxxxxxx; linux- > i2c@xxxxxxxxxxxxxxx; sameo@xxxxxxxxxxxxxx; wim@xxxxxxxxx; > timo.t.kokkonen@xxxxxxxxx; ben-linux@xxxxxxxxx; lrg@xxxxxxxxxxxxxxx; Nayak, > Rajendra > Subject: Re: [RFC][PATCH v2 4/4] OMAP4: PMIC: Update TWL mfd driver to > create twl6030 regulators > > * Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> [090803 17:23]: > > On Wed, Jul 29, 2009 at 10:06:13AM +0530, balajitk@xxxxxx wrote: > > > > > - if (twl_has_regulator()) { > > > + if (twl_has_regulator() && is_class_twl4030()) { > > > > is_class_twl4030() feels like it should have better namespacing, though > > having the part name in there means it's not actually an issue. > > How about twl_is_4030()? The idea was to have a class of twl4030 IC's type IC's. There are many of them with just different name (TPS *) ... twl_class_is_4030().... What you say ? Can I suggest: pmic_class_is_xxx() ? Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
