Nishanth, On 17/12/2021 18:14, Nishanth Menon wrote: > On 12:29-20211217, Roger Quadros wrote: >> The GPMC controller is present on some K3 SoCs. >> It provides access to NOR/NAND flashes and asynchronous >> SRAM-like memories and ASICs. >> >> Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx> >> --- >> arch/arm64/Kconfig.platforms | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 1aa8b7073218..f447b120f863 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -122,6 +122,7 @@ config ARCH_K3 >> select TI_SCI_INTR_IRQCHIP >> select TI_SCI_INTA_IRQCHIP >> select TI_K3_SOCINFO >> + select OMAP_GPMC > I dont think GPMC should be part of the select list here. instead > defconfig patch is prefered. the existance and usage of the same are > limited and it is NOT a core functional component required to boot up a > K3 platform. > Since OMAP_GPMC is not visible it cannot be enabled via defconfig file. I tried to make it visible in earlier revision of this patchset but it looks like OMAP_GPMC config was meant to be not a visible option form the beginning. All legacy platforms have been selecting it in some way or the other but I agree with you that selecting it at SOC level may not be the best option. If not here, any suggestions where should I select it from? Maybe from mtd/nand/raw/Kconfig if GPMC NAND driver is enabled? cheers, -roger
