Re: [RFC] [PATCH 3/3 v2] ASoC: add support for Amstrad E3 (Delta) machine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Brown wrote:
On Wed, Jul 29, 2009 at 01:18:53PM +0200, Janusz Krzysztofik wrote:

2) patch 2/3 form this series: TTY: Add definition of a new line
   discipline required by Amstrad E3 (Delta) ASoC driver[2].

The ASoC parts of this all look OK - what's the status of the TTY patch?


Alan replied off-list yet before v2 submission. Then I replied him off-list as well... I hope he doesn't mind quoting him here.

Janusz Krzysztofik wrote:
Alan Cox wrote:
Interesting use of a line discipline. The tty/ldisc bits look good to me


Thanks.
Could you please have a look at today's version 2 of the patch 3/3 as well? The ldisc bits has been split into machine and codec related parts and, what's more important, updated with locking that I am not quite sure about its correctness.

Furthermore, I am still thinking about renaming the ldisc with a more generic name. That way, it could be probably reused by other similiar implementations. As long as the ldisc is registered from a board specific code, it should not interfere with other implemnetations reusing the same ldisc number, even if compiled in side by side.

Any objections on renaming ldisc from N_AMSDLETA to N_V253?

Thnaks,
Janusz

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux