On Thu, 30 Jul 2009 15:49:43 +0300
Eduardo Valentin <eduardo.valentin@xxxxxxxxx> wrote:
> @@ -321,8 +326,11 @@ static int omap_mcbsp_dai_set_dai_fmt(struct
> snd_soc_dai *cpu_dai, /* Generic McBSP register settings */
> regs->spcr2 |= XINTM(3) | FREE;
> regs->spcr1 |= RINTM(3);
> - regs->rcr2 |= RFIG;
> - regs->xcr2 |= XFIG;
> + /* RFIG and XFIG are not defined in 34xx */
> + if (!cpu_is_omap34xx()) {
> + regs->rcr2 |= RFIG;
> + regs->xcr2 |= XFIG;
> + }
This is true. These bits are marked as reserved read only bits in 34xx.
I'm fine if you do change here in this patch but I can add immediate
acked-by if you want to post this as a separate change for 2.6.32
(setting them for 34xx is null-op at the moment AFAIK).
If you find generic fix for channel switching problem found also from
older OMAP's like 2420 then I give you a deep bow and acked-by for
2.6.31!
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
