On Mon, Jul 27, 2009 at 11:14:48AM -0700, Andrew Morton wrote: > On Mon, 27 Jul 2009 14:02:47 +0300 Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > > > Matt Fleming wrote: > > > On Mon, Jul 27, 2009 at 10:15:11AM +0100, Matt Fleming wrote: > > >> On Mon, Jul 27, 2009 at 11:58:22AM +0300, Adrian Hunter wrote: > > >>> Yes much nicer. Will you add it to your patch? > > >> Sure, I'll reply with an updated patch to 07/32 of this series. > > >> > > >> Thanks Adrian. > > > > > > OK, slight problem. If I change omap_hsmmc.c in 07/32 you'll need to > > > respin all your patches from [PATCH 08/32] onwards. Is that OK with you? > > > > I'd like to know what Andrew wants to do, as these patches are in mm tree. > > > > In the past I have seen him ask for changes to be patched on top, rather than > > make a new patch. > > > > Otherwise I am happy to redo the patch set. > > Respinning the patchset produces the nicest result, but if it's just a > matter of one modest fixup patch to be applied after the 32-patch > series then I don't think it'll kill anyone. My only worry is that if we have a fixup patch at the end of the series then we break bisection because the omap_hsmmc driver will not work from 07/32 until the fixup patch. I think the only two options are, a) move patch 07/32 to the end of the series (I can do the fix on top then, no problems). b) respin the all patches from 07/32 onwards. Adrian, how feasible is option a)? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html