Re: [PATCH resend net-next 2/2] net: bridge: switchdev: include local flag in FDB notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/04/2021 19:52, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> 
> As explained in bugfix commit 6ab4c3117aec ("net: bridge: don't notify
> switchdev for local FDB addresses") as well as in this discussion:
> https://lore.kernel.org/netdev/20210117193009.io3nungdwuzmo5f7@skbuf/
> 
> the switchdev notifiers for FDB entries managed to have a zero-day bug,
> which was that drivers would not know what to do with local FDB entries,
> because they were not told that they are local. The bug fix was to
> simply not notify them of those addresses.
> 
> Let us now add the 'is_local' bit to bridge FDB entries, and make all
> drivers ignore these entries by their own choice.
> 
> Co-developed-by: Tobias Waldekranz <tobias@xxxxxxxxxxxxxx>
> Signed-off-by: Tobias Waldekranz <tobias@xxxxxxxxxxxxxx>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> ---
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c        | 4 ++--
>  drivers/net/ethernet/marvell/prestera/prestera_switchdev.c | 2 +-
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c   | 5 +++--
>  drivers/net/ethernet/rocker/rocker_main.c                  | 4 ++--
>  drivers/net/ethernet/ti/am65-cpsw-switchdev.c              | 4 ++--
>  drivers/net/ethernet/ti/cpsw_switchdev.c                   | 4 ++--
>  include/net/switchdev.h                                    | 1 +
>  net/bridge/br_switchdev.c                                  | 3 +--
>  net/dsa/slave.c                                            | 2 +-
>  9 files changed, 15 insertions(+), 14 deletions(-)
> 

For the bridge change:
Acked-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxx>





[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux