Hi Felipe, From: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@xxxxxxxxx> Subject: Re: [RFC][PATCH 2/3] ARM:OMAP4 iommu:add omap4 support in iommu Date: Fri, 24 Jul 2009 20:27:02 +0200 > On Fri, Jul 24, 2009 at 07:22:32PM +0200, ext Kanigeri, Hari wrote: > > This patch adds omap4 support in iommu > > module. This creates OMAP4 platform specific file > > for iommu and defines the Ducati MMU fault interrupt. > > > > Signed-off-by: Hari Kanigeri <h-kanigeri2@xxxxxx> > > --- > > arch/arm/mach-omap2/omap4-iommu.c | 112 ++++++++++++++++++++++++++++++++ > > arch/arm/plat-omap/include/mach/irqs.h | 2 +- > > 2 files changed, 113 insertions(+), 1 deletions(-) > > create mode 100644 arch/arm/mach-omap2/omap4-iommu.c > > > > diff --git a/arch/arm/mach-omap2/omap4-iommu.c b/arch/arm/mach-omap2/omap4-iommu.c > > new file mode 100644 > > index 0000000..5a782df > > --- /dev/null > > +++ b/arch/arm/mach-omap2/omap4-iommu.c > > @@ -0,0 +1,112 @@ > > +/* > > + * omap iommu: omap4 device registration > > + * > > + * Copyright (C) 2009-2010 Nokia Corporation > > + * > > + * Written by Hari Kanigeri <h-kanigeri2@xxxxxx> > > + * > > + * Added support for OMAP4. This is based on original file > > + * omap3-iommu.c > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > + > > +#include <linux/platform_device.h> > > + > > +#include <mach/iommu.h> > > +#include <mach/irqs.h> > > + > > +#define OMAP4_MMU1_BASE 0x55082000 > > +#define OMAP4_MMU2_BASE 0x4A066000 > > + > > +#define OMAP4_MMU1_IRQ INT_44XX_DUCATI_MMU_IRQ > > +#define OMAP4_MMU2_IRQ INT_44XX_DSP_MMU > > + > > + > > + > > +static unsigned long iommu_base[] __initdata = { > > + OMAP4_MMU1_BASE, > > + OMAP4_MMU2_BASE, > > +}; > > + > > +static int iommu_irq[] __initdata = { > > + OMAP4_MMU1_IRQ, > > + OMAP4_MMU2_IRQ, > > +}; > > these two looks really odd :-s I think that the above just follows Russeell's proposal as below: http://lists.arm.linux.org.uk/lurker/message/20090516.092036.df9420d1.en.html > > > + > > +static const struct iommu_platform_data omap4_iommu_pdata[] __initconst = { > > + { > > + .name = "ducati", > > + .nr_tlb_entries = 32, > > + .clk_name = "ducati_ick", > > passing clk names should be avoided. use clkdev. > > > + }, > > +#if defined(CONFIG_MPU_TESLA_IOMMU) > > this ifdef looks odd. > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html