Re: [PATCHv2 6/6] drm/omapdrm/dss/hdmi5: add CEC support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/03/2021 18:24, Hans Verkuil wrote:
Add HDMI CEC support for OMAP5.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
---
  drivers/gpu/drm/omapdrm/Kconfig          |   8 +
  drivers/gpu/drm/omapdrm/Makefile         |   1 +
  drivers/gpu/drm/omapdrm/dss/hdmi.h       |   1 +
  drivers/gpu/drm/omapdrm/dss/hdmi5.c      |  63 +++++--
  drivers/gpu/drm/omapdrm/dss/hdmi5_cec.c  | 209 +++++++++++++++++++++++
  drivers/gpu/drm/omapdrm/dss/hdmi5_cec.h  |  42 +++++
  drivers/gpu/drm/omapdrm/dss/hdmi5_core.c |  35 +++-
  drivers/gpu/drm/omapdrm/dss/hdmi5_core.h |  33 +++-
  8 files changed, 373 insertions(+), 19 deletions(-)
  create mode 100644 drivers/gpu/drm/omapdrm/dss/hdmi5_cec.c
  create mode 100644 drivers/gpu/drm/omapdrm/dss/hdmi5_cec.h

<snip>

diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
index 070cbf5fb57d..a83b634f6011 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
@@ -30,8 +30,18 @@
  #define HDMI_CORE_IH_PHY_STAT0			0x00410
  #define HDMI_CORE_IH_I2CM_STAT0			0x00414
  #define HDMI_CORE_IH_CEC_STAT0			0x00418
+#define CEC_STAT_DONE				BIT(0)
+#define CEC_STAT_EOM				BIT(1)
+#define CEC_STAT_NACK				BIT(2)
+#define CEC_STAT_ARBLOST			BIT(3)
+#define CEC_STAT_ERROR_INIT			BIT(4)
+#define CEC_STAT_ERROR_FOLL			BIT(5)
+#define CEC_STAT_WAKEUP				BIT(6)
+
  #define HDMI_CORE_IH_VP_STAT0			0x0041C
  #define HDMI_CORE_IH_I2CMPHY_STAT0		0x00420
+#define HDMI_CORE_IH_MUTE_I2CM_STAT0            0x00614

The line above has indentation in spaces, but everything else uses tabs.

Other than that:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

 Tomi



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux