On Fri, 12 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-02-12 13:26:30) > > On Fri, 12 Feb 2021, Lee Jones wrote: > > > > > The alternative is to not worry about it and review the slow drip of > > > fixes that will occur as a result. The issues I just fixed were built > > > up over years. They won't get to that level again. > > > > > > In my mind contributors should be compiling their submissions with W=1 > > > enabled by default. I'm fairly sure the auto-builders do this now. > > That's good. > > > > > > > Once W=1 warnings are down to an acceptable level in the kernel as a > > > whole, we can provide some guidance in SubmittingPatches (or similar) > > > on how to enable them (hint: you add "W=1" on the compile line). > > > > > > Enabling W=1 in the default build will only serve to annoy Linus IMHO. > > > If he wants them to be enabled by default, they wouldn't be W=1 in the > > > first place, they'd be W=0 which *is* the default build. > > > > Just to add real quick - my advice is to enable them for yourself and > > send back any issues along with your normal review. A W=1 issue is no > > different to a semantic or coding style one. > > > > I'd like to enable it for only files under drivers/clk/ but it doesn't > seem to work. I'm not asking to enable it at the toplevel Makefile. I'm > asking to enable it for drivers/clk/ so nobody has to think about it now > that you've done the hard work of getting the numbers in this directory > down to zero or close to zero. I'm not sure which one of us is confused. Probably me, but ... Even if you could enable it per-subsystem, how would that help you? How can you ensure that contributors see any new W=1 warnings, but Linus doesn't? When Linus conducts his build-tests during the merge window, he is also going to build W=1 for drivers/clk. All that's going to achieve is put you in the firing line. >From my PoV W=1 builds should be enabled during the development phase (i.e. contributor, auto-builder, maintainer). By the time patches get make it into Mainline the review/testing stage is over and only the default W=0 warnings are meaningful. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
