On 12/02/2021 17:15, Vladimir Oltean wrote: > From: Vladimir Oltean <vladimir.oltean@xxxxxxx> > > If for example this command: > > ip link set swp0 type bridge_slave flood off mcast_flood off learning off > > succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at > BR_LEARNING, there would be no attempt to revert the partial state in > any way. Arguably, if the user changes more than one flag through the > same netlink command, this one _should_ be all or nothing, which means > it should be passed through switchdev as all or nothing. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx> > --- > Changes in v5: > None. > > Changes in v4: > Leave br->lock alone completely. > > Changes in v3: > Don't attempt to drop br->lock around br_switchdev_set_port_flag now, > move that part to a later patch. > > Changes in v2: > Patch is new. > > Changes in v2: > Patch is new. > > net/bridge/br_netlink.c | 109 ++++++++++++-------------------------- > net/bridge/br_switchdev.c | 6 ++- > 2 files changed, 39 insertions(+), 76 deletions(-) > LGTM, thanks! Acked-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxx>
