Hi Tony,
On 05/02/2021 15:30, Tony Lindgren wrote:
* Ivan J. <parazyd@xxxxxxxx> [210205 13:18]:
On Fri, Feb 05, 2021 at 03:15:00PM +0200, Grygorii Strashko wrote:
On 04/02/2021 08:56, Tony Lindgren wrote:
* Ivan Jelincic <parazyd@xxxxxxxx> [210203 13:35]:
Update omap2plus_defconfig for options that have been dropped:
- SIMPLE_PM_BUS no longer selected.
Oh right, we now need to always select it. Will queue this for
fixes after the merge window. The other one I'll be queueing
for v5.13 as the merge window is about to open and I'll only
queue fixes for the next few weeks :)
"- MICREL_PHY no longer selected."
I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no
explicit dependency from KS8851, but MICREL PHYs are in use.
So, I'd prefer to have it enabled explicitly in omap2plus_defconfig.
And not sure what exactly "no longer selected" means.
"no longer selected" means it went away after `make savedefconfig`.
Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig
for the other cases that do not use KS8851?
The KS8851 config was added like 10years ago and is used on some omap4 platforms,
it does select MICREL_PHY.
From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851.
The omap2plus_defconfig is also used as base for custom configs and first thing people are doing -
remove not needed options. As result, removal of KS8851 plus this patch will immediately
cause MICREL_PHY=n and so breakage on existing and custom platforms.
I do not see how it can be resolved by using Kconfig changes within much-omap2.
So, sry, but NACK for this patch as it is.
if some Kconfig dependencies need to be sorted out - probably the best way might be
to get rid of select MICREL_PHY in KS8851/KS8851_MLL.
--
Best regards,
grygorii
