On Wed, Jul 22, 2009 at 11:22 AM, Hiroshi DOYU<Hiroshi.DOYU@xxxxxxxxx> wrote: > Both functions are almost same structure except its flag passed to > MEM_FlushCache(). > > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> > --- > drivers/dsp/bridge/rmgr/proc.c | 82 ++++++++++++++++++--------------------- > 1 files changed, 38 insertions(+), 44 deletions(-) > + enum DSP_FLUSHTYPE mtype = PROC_WRITEBACK_INVALIDATE_MEM; > + > + return proc_memory_sync(hProcessor, pMpuAddr, ulSize, ulFlags, mtype); > +} What's wrong with sending the type directly? return proc_memory_sync(hProcessor, pMpuAddr, ulSize, ulFlags, PROC_WRITEBACK_INVALIDATE_MEM); > + enum DSP_FLUSHTYPE mtype = PROC_INVALIDATE_MEM; > + > + return proc_memory_sync(hProcessor, pMpuAddr, ulSize, 0, mtype); > } ditto And while we are at it, why only PROC_WRITEBACK_INVALIDATE_MEM and PROC_INVALIDATE_MEM? How shall user-space issue a call for PROC_WRITEBACK_MEM? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html