Re: [PATCH v4 62/80] drm/omap: dsi: simplify VC handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/11/2020 12:00, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Tue, Nov 24, 2020 at 02:45:20PM +0200, Tomi Valkeinen wrote:
>> The VC handling has gotten quite tangled up. As the first step to clean
>> it up, lets define that we only support a single DSI peripheral (which
>> was really already the case), and we always use VC0 (define VC_DEFAULT
>> 0) register block to send data to the peripheral.
>>
>> We can thus have a single mipi_dsi_device pointer and remove the for
> 
> s/the for/the need for/ ?

Hmm, no, that's not what I was trying to say. Maybe it's clearer with a dash: "remove the for-loops
which..."

> 
>> loops which made passes over all the four VCs (just the first one was
>> ever used).
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux