Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:13PM +0200, Tomi Valkeinen wrote: > Use the common MIPI_DCS_GET_ERROR_COUNT_ON_DSI define instead of > driver's own. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/panel/panel-dsi-cm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c > index 35a0c7da1974..cb0d27a38555 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -27,7 +27,6 @@ > #include <video/of_display_timing.h> > #include <video/videomode.h> > > -#define DCS_READ_NUM_ERRORS 0x05 > #define DCS_GET_ID1 0xda > #define DCS_GET_ID2 0xdb > #define DCS_GET_ID3 0xdc > @@ -225,7 +224,7 @@ static ssize_t num_dsi_errors_show(struct device *dev, > mutex_lock(&ddata->lock); > > if (ddata->enabled) > - r = dsicm_dcs_read_1(ddata, DCS_READ_NUM_ERRORS, &errors); > + r = dsicm_dcs_read_1(ddata, MIPI_DCS_GET_ERROR_COUNT_ON_DSI, &errors); > > mutex_unlock(&ddata->lock); > -- Regards, Laurent Pinchart
