On Sun, 15 Nov 2020, Dmitry Osipenko wrote: > Correct power-off programming sequence in order to fix shutting down > devices which are using TPS65910 PMIC. > > In accordance to the TPS65910 datasheet, the PMIC's state-machine > transitions into the OFF state only when DEV_OFF bit of DEVCTRL_REG is > set. The ON / SLEEP states also should be cleared, otherwise PMIC won't > get into a proper state on shutdown. Devices like Nexus 7 tablet and Ouya > game console are shutting down properly now. > > Tested-by: Peter Geis <pgwipeout@xxxxxxxxx> > Tested-by: Zack Pearsall <zpearsall@xxxxxxxxx> > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > > Changelog: > > v4: - Rebased on a recent linux-next. > > v3: - Removed the DEV_SLP_MASK clearing and adding clarifying comment to > the code about why clearing PWR_OFF bit needs to be done, which was > suggested by Michał Mirosław in a review comment to v2. > > - Added tested-by from Peter Geis who tested v3 on his Ouya game > console. > > v2: - Now using a single tps65910_reg_update_bits() instead of set+clear. > Thanks to Michał Mirosław for the suggestion. > > drivers/mfd/tps65910.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
