Hi Suman, On Tue, 10 Nov 2020 at 21:43, Suman Anna <s-anna@xxxxxx> wrote: > > Hi Greg, > > On 10/26/20 9:49 AM, Grzegorz Jaszczyk wrote: > > Since the of_device_get_match_data() doesn't return error code, remove > > wrong IS_ERR test. Proper check against NULL pointer is already done > > later before usage: if (data && data->...). > > > > Additionally, proceeding with empty device data is valid (e.g. in case > > of "ti,am3356-pruss"). > > > > Reported-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > Please add the appropriate Fixes: tag. > > And prefer %s/Remove/Fix/ in patch title. Sure. > > With that, > Acked-by: Suman Anna <s-anna@xxxxxx> Thank you, I will post v2 with all improvements soon. Best regards, Grzegorz
