Re: [PATCH] ARM: multi_v7_defconfig: ti: Enable networking options for nfs boot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd,

On 29/10/2020 22:06, Arnd Bergmann wrote:
On Thu, Oct 29, 2020 at 8:15 PM Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:
On 02/10/2020 15:50, Nishanth Menon wrote:
On 23:27-20201001, Grygorii Strashko wrote:
Enable networking options required for NFS boot on TI platforms, which is
widely for automated test systems.
- enable new TI CPSW switch driver and related NET_SWITCHDEV config
- enable TI DP83867 phy
- explicitly enable PTP clock support to ensure dependent networking
drivers will stay built-in

Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
---
   arch/arm/configs/multi_v7_defconfig | 5 +++++
   1 file changed, 5 insertions(+)


[...]

Reviewed-by: Nishanth Menon <nm@xxxxxx>


Are there any actions need to be done to have this patch merged?

I would prefer if a platform maintainer (I assume Tony in this case)
picks it up and forwards it to soc@xxxxxxxxxx together with other
related changes. Olof and I tend to ignore patches sent directly
to us, so we don't get in the way of platform maintainers that
may have already merged similar patches or have comments.

I suspect Tony didn't pick it up either because from the patch
subject and the description, it is not clear that he is the one
to act on it. It helps to be more specific and ask the maintainer
by addressing them in person below the '---' line, as well as
only putting one person in 'To:' and the rest in 'Cc:'.

Thanks for your comments and sorry that I disturbed you.

But, honestly, I'm confused (and probably I'm not the first one) as multi_v7 is common
for all ARM platforms while change is TI OMAP specific,
and neither Documentation neither get_maintainer.pl provide any reliable information
on how to proceed :( and who should be responsible for merging multi_x patches.

I'd really have tried to do some checking while preparing patch and TO/CC list - some patches applied by
platform maintainers, but some by top ARM maintainers.


One comment on the contents of the patch: IIRC this is a fairly
large driver. To ensure we don't burden other users too much,
can you include the size of the vmlinux file before and after
this patch?

before:
   text	   data	    bss	    dec	    hex	filename
14703736	8024602	 444976	23173314	16198c2	./omap-arm/vmlinux

after:
   text	   data	    bss	    dec	    hex	filename
14727271	8029150	 444528	23200949	16204b5	./omap-arm/vmlinux

diff: 27635 (dec)

--
Best regards,
grygorii



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux