On Fri, 11 Sep 2020 at 16:48, Roger Quadros <rogerq@xxxxxx> wrote:
>
> Hi Krzysztof,
>
> On 11/09/2020 17:32, Krzysztof Kozlowski wrote:
> > SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
> > linking:
> >
> > /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
> > omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
> >
> > Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > ---
> > drivers/memory/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> > index 8072204bc21a..00e013b14703 100644
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -104,6 +104,7 @@ config TI_EMIF
> >
> > config OMAP_GPMC
> > bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> > + depends on OF_ADDRESS
>
> but of_platform_device_create() is defined in platform.c which gets built
> irrespective of OF_ADDRESS.
>
> Maybe we need to just depend on CONFIG_OF ?
No, the of_platform_device_create() is defined there within #ifdef
CONFIG_OF_ADDRESS
The CONFIG_OF was already selected and was not enough.
Other solution is "depends on !SPARC"...
Best regards,
Krzysztof
